Merged
Conversation
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
Caution
Changes requested ❌
Reviewed everything up to 5d794a9 in 1 minute and 23 seconds. Click for details.
- Reviewed
28lines of code in2files - Skipped
0files when reviewing. - Skipped posting
2draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. db-scripts/01-api-key.sql:5
- Draft comment:
The email field is now set to ('' || ''), which is an unnecessarily complex way to represent an empty string. Consider using '' directly and ensure this is the intended value. - Reason this comment was not posted:
Marked as duplicate.
2. es-scripts/init-indices.sh:157
- Draft comment:
The key renamed from 'ipfs' to 'filecoin'. Confirm that this change is intentional and that all dependent code is updated accordingly. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =50%<= threshold50%The comment asks for confirmation of an intentional change, which is allowed. However, it also asks to ensure that all dependent code is updated, which violates the rules. The comment is partially useful but needs modification to comply with the rules.
Workflow ID: wflow_KUVv7iNvEwIippqJ
You can customize 
There was a problem hiding this comment.
Important
Looks good to me! 👍
Reviewed bb0aa13 in 45 seconds. Click for details.
- Reviewed
15lines of code in1files - Skipped
0files when reviewing. - Skipped posting
2draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. db-scripts/01-api-key.sql:5
- Draft comment:
Good clean-up of SQL. Confirm that 'foo@example.com' is the intended email value. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold50%This comment is asking the PR author to confirm their intention regarding the email value, which violates the rule against asking for confirmation of intention.
2. db-scripts/01-api-key.sql:5
- Draft comment:
Consider appending a trailing newline for POSIX compatibility. - Reason this comment was not posted:
Comment was on unchanged code.
Workflow ID: wflow_tay10xK6sZG4tZty
You can customize
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
Update email in SQL script and rename field in Elasticsearch script.
db-scripts/01-api-key.sqlfromfoo@bar.comtofoo@example.com.ipfstofilecoinines-scripts/init-indices.shwithin the Elasticsearch index mapping.This description was created by
for bb0aa13. You can customize this summary. It will automatically update as commits are pushed.